Cleaner DealInfo screen #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
…uilt Pressable component works Signed-off-by: Josh Leyshon <[email protected]>
…Header Signed-off-by: Josh Leyshon <[email protected]>
…ter later Signed-off-by: Josh Leyshon <[email protected]>
…nent. Use it fro DealCard Signed-off-by: Josh Leyshon <[email protected]>
…s need to wrap it in a Card if they want Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
…prices in deal titles Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
…ts out Links, the other parts still have html tags in them Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
… not clickable yet. Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
Signed-off-by: Josh Leyshon <[email protected]>
… this lets us now keep tables and other special formatting Signed-off-by: Josh Leyshon <[email protected]>
…g the amount of description TextParts to render Signed-off-by: Josh Leyshon <[email protected]>
… flex-basis doesn't work as expected there, but can use grow and shrink instead. Signed-off-by: Josh Leyshon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced old DealInfo screen with new Card based design.
Removed old VoteButtons, since for the foreseeable future we won't support logging in anyway.
Added new
TextPartobject and system. Dealtitleanddescriptions are now "parted" as part of parsing. Parts are for highlighting parts of text based on what they are, like a price in a title or a link in a description. Rendering TextParts is still simple, just render them in<Text>s next to each other.Added new base
Cardcomponent for wrapping any react node.Refactored
DealCardto actually just export the info within the card. Now up to callers to wrap the info in aCard. This lets us reuse the info components in DealInfo screen with a different card wrapper.Change base Button component to only accept base colours.
Button also can now resize to fit content with new
fitContentprop.Add base Link component, built on Text.
Extracted
openLink()function DealInfo screen tobase/links/.Screenshots
Screenshots taken in Firefox mobile emulator, so fonts aren't as nice as on mobile.