Delete command should not error out if there are no existing snapshots #13
Conversation
|
@josh-padnick This is a pretty trivial change, so I'm going to merge it in once tests pass. |
|
|
||
| * BUG: The ec2-snapper `delete` command now gracefully exits if no snapshots exist for the given instance rather than | ||
| exiting with an error. | ||
|
|
There was a problem hiding this comment.
It may be worth standardizing on adding a CHANGELOG.md to every repo, rather than relying solely on release notes. I find this a pretty efficient way to track changes. Thoughts?
There was a problem hiding this comment.
I'm of the opposite opinion. I find it hard to remember to update the CHANGELOG, whereas the release UI prompts you for info, and so it's obvious you need to update that. Moreover, as a user, as part of my natural workflow, I'll go to the release page to figure out what's the latest version and download binaries (if applicable). On the other hand, I'd have to go out of my way to check a CHANGELOG. Therefore, my vote is definitely on stick with purely release notes and not a separate file.
There was a problem hiding this comment.
My comment was motivated mainly by how, with Terraform, in particular, I regularly check the CHANGELOG to see what's new. It's nice to go to one file, to see what's in progress before it's published, and to have it all in one place.
But it's a mild preference for me, not a strong one, so if you'd prefer to stick with releases, I'm ok with that.
I had a case where I just created a new EC2 Instance and configured ec2-snapper to run on a periodic basis to backup that instance and to clean up old backups. However, when I ran the
deletecommand the first time, having not created any backups before that, I got an error. I’ve updated the code to have thedeletecommand exit gracefully if there are no backups to clean up.