Add Suspended as valid acct state #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Okta status SUSPENDED as valid state. This is to prevent users who are in suspended status from blocking eng_meta PRs. Typically, immediate terminations and 60-day inactive accounts result in a Suspended status. While terra_org could demand the suspended account be removed, it feels pretty heavy-handed. (app depro's and such)
|
This is interesting, how often do SUSPENDED's go back to ACTIVE? Isn't it a pretty 'terminal' thing? |
|
it's not as rare as you'd expect... maybe 5 times in 2020. Sometimes triggered by suspicious activity which turns out to be a false positive. |
|
also, if an actual term, since the access is effectively removed for the user (we're even locking the device), there is not a lot of risk in leaving this in until the actual termination date. |
|
Seems fine. Can you take care of the version bump and this would be good to go! As a bonus, you could document the rationale for including each active state right above the variable. |
Add Suspended as valid status
Describing why ACTIVE, PASSWORD_EXPIRED, and SUSPENDED are considered ACTIVE by terraorg
PabloValarezo
commented
Jan 16, 2021
joshk0
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Okta status SUSPENDED as valid state. This is to prevent users who are in suspended status from blocking eng_meta PRs. Typically, immediate terminations and 60-day inactive accounts result in a Suspended status.
While terra_org could demand the suspended account be removed, it feels pretty heavy-handed. (app depro's and such)