Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Associate Validation #7

Closed
wants to merge 11 commits into from
Closed

Cleanup Associate Validation #7

wants to merge 11 commits into from

Conversation

zcicala
Copy link

@zcicala zcicala commented Oct 14, 2020 •
edited
Loading

  • properly print list of failures for associates without squad
  • make squadless associate validation configurable
  • refactor tests to not use hardcoded json
  • add tests for associate validation

@zcicala
Copy link
Author

zcicala commented Oct 14, 2020

I was just rereading the commit message for 4.0.0 about the associate validation. Do you recall weird behavior thats caused by the orphaned associates?

Seems like we have several people in this state at LR. I would like to be able to move forward with the gsuite changes without blocking on cleaning up the orphans

joshk0
joshk0 requested changes Oct 14, 2020
View reviewed changes
Copy link
Owner

@joshk0 joshk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple tweaks and we will be good to go. Why not bump the version to 0.5.1 while you're at it, too, to make the eventual release easier?

lib/terraorg/model/org.rb Outdated Show resolved Hide resolved
lib/terraorg/model/org.rb Outdated Show resolved Hide resolved
lib/terraorg/model/org.rb Outdated Show resolved Hide resolved
test/terraorg/model/org_test.rb Show resolved Hide resolved
test/terraorg/model/org_test.rb Show resolved Hide resolved
joshk0 added a commit that referenced this pull request Oct 14, 2020
@joshk0
Cleanup Associate Validation (#7)
bd36f23 
* Bump version 0.5.1
* Fix associate validation bug, add tests, make associate check optional

Manual squash merge of #7

Co-Authored-By: Joshua Kwan <[email protected]>
@joshk0
Copy link
Owner

joshk0 commented Oct 14, 2020

Had to do a manual squash merge: bd36f23

@joshk0 joshk0 closed this Oct 14, 2020
@joshk0
Copy link
Owner

joshk0 commented Oct 14, 2020

Released as 0.5.1, give it a shot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshk0 joshk0 joshk0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcicala @joshk0