Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship v2.0.0 #142

Merged
merged 74 commits into from
Aug 23, 2024
Merged

Ship v2.0.0 #142

merged 74 commits into from
Aug 23, 2024

Conversation

joshmedeski
Copy link
Owner

@joshmedeski joshmedeski commented Aug 23, 2024 •
edited
Loading

This is a full rewrite of sesh, it's finally here!

Here are some notable changes:

  1. I'm now using a dependency injection pattern, so every area of the application can be tested
  2. I'm using Mockery for automated mocking
  3. The connect logic got simplified and restructured. There are now "strategies" that are more concise and clear, making sesh's connect behavior more predictable

Breaking changes:

  1. startup_script is now dropped. I recommend you make your script files executable then change any startup_script configurations to startup_command

Closes #99

@joshmedeski
chore: merge cmds package into seshcli
a843548
@joshmedeski
chore: remove v1 codebase
128f96b 
To do a proper v2 rewrite, I'd like to start from scratch and pull code
from v1 as I see fit.
@joshmedeski
feat: create execwrap package
6953069
@joshmedeski
chore: cleanup go mod
35d9bdb
@joshmedeski
feat: create shell package
408ad17
@joshmedeski
feat: add name to "New" commands
7790df9
@joshmedeski
feat: add working tmux list with tests
579c352
@joshmedeski
feat: list tmux session from CLI
ac2e33a
@joshmedeski
feat: list zoxide results from query
ae80a95
@joshmedeski
feat: improve string to float error handling
a1260f3
@joshmedeski
fix: zoxide query to include score and trim empty lines
1a2053c
@joshmedeski
feat: add zoxide to session list and cli list
63e15e6
@joshmedeski
chore: remove unused files
0f61c23
@joshmedeski
feat: create oswrap package and implement UserHomeDir
e9bce15
@joshmedeski
feat: create path package to shorten and expand home
5c60a7f
@joshmedeski
feat: shorten zoxide session name with path
08be547
@joshmedeski
feat: rename path package to home
cfeb105
@joshmedeski
chore: simplify type definitions with wrap
220acf9
@joshmedeski
feat: add ability to list config sessions
374f69b
@joshmedeski
chore: move dependencies to app
8b4a69f
@joshmedeski
feat: add mockery config file
66ec5f8
@joshmedeski
feat: add mockery generated files
d8e0c68
@joshmedeski
chore: simplify "list" file names
2c22a00
@joshmedeski
refactor: change session to lister package and test
09de00d
@joshmedeski
chore: rename lister list file
b52b432
@joshmedeski
feat: upgrade mockery config to v3
5a6d55a 
https://vektra.github.io/mockery/v2.43/migrating_to_packages/#adjacent-to-interface
@joshmedeski
feat: pass parsed config as dep
2fbeb72
@joshmedeski
feat: rework list to use maps and create tmux connection
273afa9
@joshmedeski
chore: update mockery version
d9bf2ce
@joshmedeski
feat: add "add" function to zoxide
dfb8986
joshmedeski and others added 26 commits July 1, 2024 09:27
@joshmedeski
feat: convert to valid name for tmux
4cce755
@joshmedeski
feat: add Query function to zoxide package
aa8e636
@joshmedeski
feat: add zoxide connector strategy
176a058
@joshmedeski
chore: update mock
55d9766
@joshmedeski
chore: simplify formatting
fe33aeb
@joshmedeski
feat: make namer strategy with bare worktree support
d4632c7
@joshmedeski
feat: add convert to namer
6c886ae
@joshmedeski
chore: remove todo
7bdcf75
@joshmedeski
chore: remove unused code
755a06b
@joshmedeski
feat[wip]: add cloner placeholder
6a62cbe
@joshmedeski
feat: add startup command
0f93be1
@joshmedeski
fix: always user ~/.config/sesh for config
b33ea83
@joshmedeski
feat: allow missing config file
f04aba8
@joshmedeski
fix: don't connect on blank string
ee34f64
@joshmedeski
feat: add icon support
ae2d6c5
@AgusDOLARD
feat: improve sesh version during local build (#141)
7a152bb 
sets the sesh -v flag version according to the latest git tag
@joshmedeski
feat: update make build to use git commit
608b9c3
@joshmedeski
Merge branch 'v2' of github.com:joshmedeski/sesh into v2
623648a
@joshmedeski
feat(wip): clone command
2886c9c
@joshmedeski
feat: update mocks
05c428d
@joshmedeski
fix: build command to start and wait
95793f8
@joshmedeski
fix: unit test
f28cd76
@joshmedeski
Merge branch 'main' of github.com:joshmedeski/sesh into v2
4e35b2c
@joshmedeski
fix: mockery exec
c5103c6
@joshmedeski
fix: simply assertion on parsing tmux sessions
8197b61
@joshmedeski
fix: simplify test
38a3d4b
@joshmedeski joshmedeski merged commit f999ba7 into main Aug 23, 2024
4 checks passed
@joshmedeski joshmedeski deleted the v2 branch August 23, 2024 02:11
@mloskot
Copy link

mloskot commented Aug 23, 2024

Thank you sooo much!

@acburdine acburdine mentioned this pull request Sep 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Injection (v2)
3 participants
@joshmedeski @mloskot @AgusDOLARD