Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add yq prior to 4.18.* support #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

realFrogboy
Copy link

@realFrogboy realFrogboy commented Nov 1, 2024

Hi, thank you for your wonderful plugin!

I've tried to install it on my machine and received the following error message:

Error: unknown command ".icons.\"vim\"" for "yq"
Run 'yq --help' for usage.
bash: [: bin/defaults.yml: integer expression expected
Error: unknown command ".config.show-name" for "yq"
Run 'yq --help' for usage.

The source of the issue was that yq on my system has 4.2.0 version and according to this discussion mikefarah/yq#1158 (comment) prior to 4.18.x eval word must be specified before the actual commands.

I've added a check of the yq version and inserted eval if it's actually required.

@joshmedeski
Copy link
Owner

Thanks for looking into this and writing up backwards compatability.

yq version 4.17 is almost 3 years old right now. So, rather than adding additional complexity to the project, are you able to upgrade yq on your machine? To my knowledge it's not something included on many operating systems so it seems reasonable to require the dependency be ya v4.18 or highter.

Let me know your thoughts, thanks.

@joshmedeski
Copy link
Owner

@realFrogboy you've got merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants