Replies: 7 comments 10 replies
-
Can you send your config or json file? Mine appears to be working. I will also commit one more time just in case. The engine has issues sometimes when coplanar objects are unioned. Not sure if that is the issue or not, but I should be able to figure it out with your config. |
Beta Was this translation helpful? Give feedback.
-
I pulled the latest commit and get this error:
Traceback (most recent call last):
File "/app/src/generate_configuration.py", line 374, in <module>
run()
File "/app/src/dactyl_manuform.py", line 3651, in run
mod_r = model_side(side="right")
File "/app/src/dactyl_manuform.py", line 3545, in model_side
shape = union([shape, sensor])
File "/app/src/helpers_cadquery.py", line 56, in union
shape = shape.union(item)
File "/opt/conda/lib/python3.9/site-packages/cadquery/cq.py", line 3242, in
union
r = r.clean()
File "/opt/conda/lib/python3.9/site-packages/cadquery/occ_impl/shapes.py",
line 389, in clean
upgrader.Build()
OCP.Standard.Standard_Failure: Courbes non jointives
>>
Is this a module/dependency problem? I'm building using Docker containers.
Attaching my json here.
When I change the engine to solid, it builds. However, the generated file
fails to render in OpenSCAD.
Thanks
…On Sat, Aug 14, 2021 at 5:14 AM Joshua Shreve ***@***.***> wrote:
Can you send your config or json file? Mine appears to be working. I will
also commit one more time just in case. The engine has issues sometimes
when coplanar objects are unioned. Not sure if that is the issue or not,
but I should be able to figure it out with your config.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUD55P5C5QDLLGUGFRUWEELT4WDKHANCNFSM5CDUGLPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Beta Was this translation helpful? Give feedback.
-
Here's my config:
{
"ENGINE": "cadquery",
"save_dir": ".",
"config_name": "DM",
"show_caps": false,
"show_pcbs": false,
"nrows": 5,
"ncols": 6,
"alpha": 0.26179916666666664,
"beta": 0.08726638888888888,
"centercol": 3,
"centerrow_offset": 3,
"tenting_angle": 0.26179916666666664,
"symmetry": "symmetric",
"column_style_gt5": "orthographic",
"column_style": "standard",
"thumb_offsets": [
6,
-3,
7
],
"keyboard_z_offset": 11,
"thumb_style": "CARBONFET",
"default_1U_cluster": false,
"minidox_Usize": 1.6,
"thumb_plate_tr_rotation": 0.0,
"thumb_plate_tl_rotation": 0.0,
"thumb_plate_mr_rotation": 0.0,
"thumb_plate_ml_rotation": 0.0,
"thumb_plate_br_rotation": 0.0,
"thumb_plate_bl_rotation": 0.0,
"trackball_in_wall": true,
"tbiw_hole_diameter": 36,
"tbiw_hole_height": 40,
"tbiw_ball_center_row": 0.2,
"tbiw_translational_offset": [
0.0,
0.0,
3
],
"tbiw_rotation_offset": [
0.0,
0.0,
0.0
],
"tbiw_left_wall_x_offset_override": 50.0,
"tbiw_left_wall_z_offset_override": 0.0,
"tbiw_left_wall_lower_y_offset": 0.0,
"tbiw_left_wall_lower_z_offset": 0.0,
"tbiw_oled_center_row": 0.75,
"tbiw_oled_translation_offset": [
-3.5,
0,
1.5
],
"tbiw_oled_rotation_offset": [
0,
0,
0
],
"other_thumb": "DEFAULT",
"tbjs_key_diameter": 64,
"tbjs_translational_offsets": [
[
0.0,
0.0,
-3.0
],
[
0.0,
0.0,
-3.0
],
[
0.0,
0.0,
-3.0
],
[
0.0,
0.0,
-3.0
]
],
"tbjs_rotation_offsets": [
[
0.0,
0.0,
0.0
],
[
0.0,
0.0,
0.0
],
[
0.0,
0.0,
0.0
],
[
0.0,
0.0,
0.0
]
],
"trackball_Usize": 1.5,
"trackball_rotation": 0.0,
"ball_side": "right",
"ball_diameter": 34.0,
"ball_wall_thickness": 5.0,
"ball_gap": 1.0,
"ball_z_offset": -3.0,
"pinky_1_5U": false,
"first_1_5U_row": 0,
"last_1_5U_row": 5,
"extra_width": 2.5,
"extra_height": 1.0,
"wall_z_offset": 15,
"wall_x_offset": 5,
"wall_y_offset": 6,
"left_wall_x_offset": 12,
"left_wall_z_offset": 3,
"left_wall_lower_y_offset": 0,
"left_wall_lower_z_offset": 0,
"wall_thickness": 4.5,
"wall_base_y_thickness": 4.5,
"wall_base_x_thickness": 4.5,
"wall_base_back_thickness": 4.5,
"fixed_angles": [
0.17453277777777776,
0.17453277777777776,
0,
0,
0,
-0.26179916666666664,
-0.26179916666666664
],
"fixed_x": [
-41.5,
-22.5,
0,
20.3,
41.4,
65.5,
89.6
],
"fixed_z": [
12.1,
8.3,
0,
5,
10.7,
14.5,
17.5
],
"fixed_tenting": 0.0,
"plate_style": "NOTCH",
"hole_keyswitch_height": 14.0,
"hole_keyswitch_width": 14.0,
"nub_keyswitch_height": 14.4,
"nub_keyswitch_width": 14.4,
"undercut_keyswitch_height": 14.0,
"undercut_keyswitch_width": 14.0,
"notch_width": 5.0,
"sa_profile_key_height": 12.7,
"sa_length": 18.5,
"sa_double_length": 37.5,
"plate_thickness": 5.1,
"plate_rim": 2.0,
"clip_thickness": 1.4,
"clip_undercut": 1.0,
"undercut_transition": 0.2,
"plate_file": null,
"plate_offset": 0.0,
"oled_mount_type": "CLIP",
"oled_center_row": 1.25,
"oled_translation_offset": [
0,
0,
4
],
"oled_rotation_offset": [
0,
0,
0
],
"oled_configurations": {
"UNDERCUT": {
"oled_mount_width": 15.0,
"oled_mount_height": 35.0,
"oled_mount_rim": 3.0,
"oled_mount_depth": 6.0,
"oled_mount_cut_depth": 20.0,
"oled_mount_location_xyz": [
-80.0,
20.0,
45.0
],
"oled_mount_rotation_xyz": [
13.0,
0.0,
-6.0
],
"oled_left_wall_x_offset_override": 28.0,
"oled_left_wall_z_offset_override": 0.0,
"oled_left_wall_lower_y_offset": 12.0,
"oled_left_wall_lower_z_offset": 5.0,
"oled_mount_undercut": 1.0,
"oled_mount_undercut_thickness": 2.0
},
"SLIDING": {
"oled_mount_width": 12.5,
"oled_mount_height": 25.0,
"oled_mount_rim": 2.5,
"oled_mount_depth": 8.0,
"oled_mount_cut_depth": 20.0,
"oled_mount_location_xyz": [
-78.0,
10.0,
41.0
],
"oled_mount_rotation_xyz": [
6.0,
0.0,
-3.0
],
"oled_left_wall_x_offset_override": 24.0,
"oled_left_wall_z_offset_override": 0.0,
"oled_left_wall_lower_y_offset": 12.0,
"oled_left_wall_lower_z_offset": 5.0,
"oled_thickness": 4.2,
"oled_edge_overlap_end": 6.5,
"oled_edge_overlap_connector": 5.5,
"oled_edge_overlap_thickness": 2.5,
"oled_edge_overlap_clearance": 2.5,
"oled_edge_chamfer": 2.0
},
"CLIP": {
"oled_mount_width": 12.5,
"oled_mount_height": 39.0,
"oled_mount_rim": 2.0,
"oled_mount_depth": 7.0,
"oled_mount_cut_depth": 20.0,
"oled_mount_location_xyz": [
-78.0,
20.0,
42.0
],
"oled_mount_rotation_xyz": [
12.0,
0.0,
-6.0
],
"oled_left_wall_x_offset_override": 24.0,
"oled_left_wall_z_offset_override": 0.0,
"oled_left_wall_lower_y_offset": 12.0,
"oled_left_wall_lower_z_offset": 5.0,
"oled_thickness": 4.2,
"oled_mount_bezel_thickness": 3.5,
"oled_mount_bezel_chamfer": 2.0,
"oled_mount_connector_hole": 6.0,
"oled_screen_start_from_conn_end": 6.5,
"oled_screen_length": 24.5,
"oled_screen_width": 10.5,
"oled_clip_thickness": 1.5,
"oled_clip_width": 6.0,
"oled_clip_overhang": 1.0,
"oled_clip_extension": 5.0,
"oled_clip_width_clearance": 0.5,
"oled_clip_undercut": 0.5,
"oled_clip_undercut_thickness": 2.5,
"oled_clip_y_gap": 0.2,
"oled_clip_z_gap": 0.2
}
},
"web_thickness": 4.0,
"post_size": 0.1,
"post_adj": 0,
"screws_offset": "INSIDE",
"screw_insert_height": 3.8,
"screw_insert_bottom_radius": 2.655,
"screw_insert_top_radius": 2.55,
"wire_post_height": 7,
"wire_post_overhang": 3.5,
"wire_post_diameter": 2.6,
"controller_mount_type": "EXTERNAL",
"external_holder_height": 12.5,
"external_holder_width": 28.75,
"external_holder_xoffset": -5.0,
"external_holder_yoffset": -4.5,
"screw_hole_diameter": 3,
"base_thickness": 3.0,
"base_offset": 3.0,
"base_rim_thickness": 5.0,
"screw_cbore_diameter": 4.0,
"screw_cbore_depth": 2.0,
"plate_holes": true,
"plate_holes_xy_offset": [
0.0,
0.0
],
"plate_holes_width": 14.3,
"plate_holes_height": 14.3,
"plate_holes_diameter": 1.7,
"plate_holes_depth": 20.0,
"pcb_width": 18.0,
"pcb_height": 18.0,
"pcb_thickness": 1.5,
"pcb_hole_diameter": 2,
"pcb_hole_pattern_width": 14.3,
"pcb_hole_pattern_height": 14.3,
"column_offsets": [
[
0,
0,
0
],
[
0,
0,
0
],
[
0,
2.82,
-4.5
],
[
0,
0,
0
],
[
0,
-6,
5
],
[
0,
-6,
5
],
[
0,
-6,
5
]
]
}
…On Sun, Aug 15, 2021 at 2:41 AM Joshua Shreve ***@***.***> wrote:
I can't find the attachment. I'm guessing there is something in the config
that creates an odd geometry, but I will check to see if I can make things
more robust. Can you try building with the current default config that is
checked in? I have that running correctly and it will tell me if the issue
is with the specific configuration or with how you configuration is
operating. I just ran through docker and had to delete and recreate the
containers. Not sure why they were misbehaving, but it ran after that.
Either way, a quick check of your config will tell me the issue. You can
also just paste it into a reply since I don't think the attachment shows
up. Or if you have it in a forked repo, I'm happy to pull it from there as
well.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUD55P3T75F6LTA3OHD5M43T422EBANCNFSM5CDUGLPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Beta Was this translation helpful? Give feedback.
-
Windows 10 fresh install. Docker, WSL2 backend. Building using docker.
Running the trackball branch. No problems in the master branch whatsoever.
Master branch works fine. Only running into errors in the trackball branch
specifically TBIW.
For the trackball branch:
Only things I changed in the config are CARBONFET thumb cluster and TBIW
set to true.
It builds in solid, previews fine in openSCAD, but render fails due to
unclosed polygons/mesh.
For CQ, it fails to build completely and I get the errors I posted before.
I did a fresh install on an new machine since installing miniconda and all
other dependencies somehow messes up ZMK. So I’m using a new machine write
a fresh install to do the tests.
Thank you!
…On Tue, Aug 17, 2021 at 10:04 AM Joshua Shreve ***@***.***> wrote:
What is your OS, setup, etc, maybe that will help. Are you running the
master or trackball branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUD55PZVRT4J3T7XMFDMPC3T5G7RFANCNFSM5CDUGLPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Beta Was this translation helpful? Give feedback.
-
Alright, I will try the hot swap pockets and report back.
…On Tue, Aug 17, 2021 at 10:10 AM Freznel Sta. Ana ***@***.***> wrote:
Windows 10 fresh install. Docker, WSL2 backend. Building using docker.
Running the trackball branch. No problems in the master branch whatsoever.
Master branch works fine. Only running into errors in the trackball branch
specifically TBIW.
For the trackball branch:
Only things I changed in the config are CARBONFET thumb cluster and TBIW
set to true.
It builds in solid, previews fine in openSCAD, but render fails due to
unclosed polygons/mesh.
For CQ, it fails to build completely and I get the errors I posted before.
I did a fresh install on an new machine since installing miniconda and all
other dependencies somehow messes up ZMK. So I’m using a new machine write
a fresh install to do the tests.
Thank you!
On Tue, Aug 17, 2021 at 10:04 AM Joshua Shreve ***@***.***>
wrote:
> What is your OS, setup, etc, maybe that will help. Are you running the
> master or trackball branch?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#28 (reply in thread)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUD55PZVRT4J3T7XMFDMPC3T5G7RFANCNFSM5CDUGLPQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
|
Beta Was this translation helpful? Give feedback.
-
I'll try that. I'm getting a new machine and install everything fresh. Ill
ty to screen record the entire process and send a link to the video.
…On Wed, Aug 18, 2021 at 7:45 PM Joshua Shreve ***@***.***> wrote:
If those work, I am really not sure. Try moving it around in XY with
'tbiw_translational_offset': (0.0, 0.0, 3). Maybe you have some marginal
condition. The thumb uses the same parts and is "harder" to construct, so I
am a bit at a loss. Sometimes you can get weird conditions on relative
positioning and tolerances when it goes to union and shifting it may break
it out of that issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUD55P4OCQCAMBEOTJ6PCOLT5OMMJANCNFSM5CDUGLPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Beta Was this translation helpful? Give feedback.
-
I just used the latest commit. OpenSCAD file opens fine but when ti try to
render I get this error:
Rendering Polygon Mesh using CGAL...
ERROR: The given mesh is not closed! Unable to convert to
CGAL_Nef_Polyhedron.
Geometries in cache: 1938
Geometry cache size in bytes: 15725800
CGAL Polyhedrons in cache: 4
CGAL cache size in bytes: 91245328
Total rendering time: 0:03:46.781
Top level object is a 3D object:
Simple: yes
Vertices: 13919
Halfedges: 62934
Edges: 31467
Halffacets: 35090
Facets: 17545
Volumes: 2
Rendering finished
The render has a hole where the sensor lens go. I opened the trackball
models in Blender and one of them has non-manifold geometry (one of the
sensor models).
Im using docker a new machine.
…On Wed, Aug 18, 2021 at 10:08 PM Freznel Sta. Ana ***@***.***> wrote:
I'll try that. I'm getting a new machine and install everything fresh. Ill
ty to screen record the entire process and send a link to the video.
On Wed, Aug 18, 2021 at 7:45 PM Joshua Shreve ***@***.***>
wrote:
> If those work, I am really not sure. Try moving it around in XY with
> 'tbiw_translational_offset': (0.0, 0.0, 3). Maybe you have some marginal
> condition. The thumb uses the same parts and is "harder" to construct, so I
> am a bit at a loss. Sometimes you can get weird conditions on relative
> positioning and tolerances when it goes to union and shifting it may break
> it out of that issue.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#28 (reply in thread)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUD55P4OCQCAMBEOTJ6PCOLT5OMMJANCNFSM5CDUGLPQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
|
Beta Was this translation helpful? Give feedback.
-
Traceback (most recent call last):
File "/app/src/generate_configuration.py", line 365, in
run()
File "/app/src/dactyl_manuform.py", line 3625, in run
mod_r = model_side(side="right")
File "/app/src/dactyl_manuform.py", line 3519, in model_side
shape = union([shape, sensor])
File "/app/src/helpers_cadquery.py", line 56, in union
shape = shape.union(item)
File "/opt/conda/lib/python3.9/site-packages/cadquery/cq.py", line 3242, in union
r = r.clean()
File "/opt/conda/lib/python3.9/site-packages/cadquery/occ_impl/shapes.py", line 389, in clean
upgrader.Build()
OCP.Standard.Standard_Failure: Courbes non jointives
Beta Was this translation helpful? Give feedback.
All reactions