-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thrax 11 Publish thrax to Sonatype #12
base: master
Are you sure you want to change the base?
Conversation
@lewismc, we're pulling Thrax into Joshua as part of the multi-core move, so that will enable an easy Maven push (joshua-thrax). Sound okay to close this out? |
An attempt at setting this was in the code, but the constant was overriden with a query to the config file.
… implement slf4j-over-log4j logging
This build has been completely converted to Maven, slf4j-over-log4j has been implemented and all forbidden API's calls have been addressed however it is not ready to be merged into master yet as
|
@mjpost is there work going on elsewhere to Mavenize Thrax? I jsut re-read your message above... which may indicate that the work has been completed elsewhere. I hope to god that this is not the case and this PR has and is time well spent. |
I'll wait for your reply here before continuing to investigate the tests. |
This PR is an attempt at Mavenizing Thrax with the attempt of having an artifact which can be pushed to Maven Central.
Essentially this PR does exactly that however it also does not correctly compile due to API changes within the most recent version of [jerboa|https://github.com/vandurme/jerboa/]. In particular the Classes which are affected are
@mjpost can you take a look at the APi changes and potentially implement them correctly as i am not sure what is going on.