Skip to content

Commit

Permalink
Port to new module API
Browse files Browse the repository at this point in the history
This ports the auth provider to the new module API of Synapse 1.46+.

Docs: https://matrix-org.github.io/synapse/latest/modules/password_auth_provider_callbacks.html

Based on anishihara@6c29f4d by @anishihara

Fixes ma1uta#9
  • Loading branch information
davidmehren committed Nov 23, 2021
1 parent 3524b47 commit b6bdebb
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 5 deletions.
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,19 @@ sudo pip install git+https://github.com/ma1uta/matrix-synapse-rest-password-prov
If the command fail, double check that the python version still matches. If not, please let us know by opening an issue.

## Configure
Add or amend the `password_providers` entry like so:
Add or amend the `modules` entry like so:
```yaml
password_providers:
modules:
- module: "rest_auth_provider.RestAuthProvider"
config:
endpoint: "http://change.me.example.com:12345"
```
Set `endpoint` to the value documented with the endpoint provider.

**NOTE:** This requires Synapse 1.46 or later! If you migrate from the legacy `password_providers`, make sure
to remove the old `RestAuthProvider` entry. If the `password_providers` list is empty, you can also remove it completely or
comment it out.

## Use
1. Install, configure, restart synapse
2. Try to login with a valid username and password for the endpoint configured
Expand Down
39 changes: 36 additions & 3 deletions rest_auth_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,20 @@
#

import logging
from typing import Tuple, Optional, Callable, Awaitable

import requests
import json
import time
import synapse
from synapse import module_api

logger = logging.getLogger(__name__)


class RestAuthProvider(object):

def __init__(self, config, account_handler):
self.account_handler = account_handler
def __init__(self, config: dict, api: module_api):
self.account_handler = api

if not config.endpoint:
raise RuntimeError('Missing endpoint config')
Expand All @@ -42,6 +45,36 @@ def __init__(self, config, account_handler):
logger.info('Endpoint: %s', self.endpoint)
logger.info('Enforce lowercase username during registration: %s', self.regLower)

# register an auth callback handler
# see https://matrix-org.github.io/synapse/latest/modules/password_auth_provider_callbacks.html
api.register_password_auth_provider_callbacks(
auth_checkers={
("m.login.password", ("password",)): self.check_m_login_password
}
)

async def check_m_login_password(self, username: str,
login_type: str,
login_dict: "synapse.module_api.JsonDict") -> Optional[
Tuple[
str,
Optional[Callable[["synapse.module_api.LoginResponse"], Awaitable[None]]],
]
]:
if login_type != "m.login.password":
return None

# get the complete MXID
mxid = self.account_handler.get_qualified_user_id(username)

# check if the password is valid with the old function
password_valid = await self.check_password(mxid, login_dict.get("password"))

if password_valid:
return mxid, None
else:
return None

async def check_password(self, user_id, password):
logger.info("Got password check for " + user_id)
data = {'user': {'id': user_id, 'password': password}}
Expand Down

0 comments on commit b6bdebb

Please sign in to comment.