Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Pick "version" of schema for output #34

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

joshuatz
Copy link
Owner

@joshuatz joshuatz commented Nov 10, 2020

This feature will let you (the user) pick a version of the schema (stable vs latest) for the generated output. This was requested / originated with #33, where it became clear that the stable schema has not been moved forward for some time, and is missing some much needed features (such as projects).

Once implemented, you should be able to pick which version of the schema you want your output to be generated for, right from the popup UI. Ideally, the extension should also remember the version you last picked, so you don't have to keep changing it if you prefer latest.

Once merged, closes #33


Remaining:

  • Implement picker in UI
  • Remember last selected option (Chrome storage?)
  • Pass selected option from UI to script, through existing setup

 - Update main spec to match spec (v0.0.16)
 - There will need to be further updates to match spec
 - This lays the main groundwork for supporting two version of the
 JSONResume spec (*stable* vs *latest*) simultaneously
 - Update TS schema files to line up with versions of the published spec
 - Deleted unused JSON template file
 - Overhaul main.js to built two versions of output and have both ready
 for output at request
 - Fixed some type issues that popped up with schema update
@joshuatz joshuatz added the wip Don't merge - WIP label Nov 10, 2020
@joshuatz joshuatz self-assigned this Nov 10, 2020
@joshuatz joshuatz mentioned this pull request Nov 10, 2020
@joshuatz joshuatz added the enhancement New feature or request label Nov 10, 2020
 - Implemented version picker dropdown in popup UI
 - Save user selection to storage, reload on popup launch
     - Add new required permission to manifest.json
 - Split "beta" section and merge on export
 - Refactor template code, move into separate file
 - Add section to README explaining schema version selection
 - Removed `exportBeyondSpec` flag (unnecessary with new version option)
@joshuatz joshuatz removed the wip Don't merge - WIP label Nov 12, 2020
@joshuatz joshuatz merged commit b42f44c into main Nov 12, 2020
@joshuatz joshuatz deleted the feature/pick-spec-version branch November 12, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Projects fail to export
1 participant