-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yahoo unhappy about crumbs #393
Comments
can you try this branch: |
Works like a charm after a quick (command-line, via
(which of course wraps the |
And just for completeness as I use this in a loop storing in Redis (details on my blog / in package |
I can confirm this fix is working for me as well. |
This seems to be caused by a missing "User-Agent" in the current request header. Ethan's patch added a user-agent in addition to improving the error message. And it's not good enough for the user-agent to be set to something. It needs to be a value the server considers valid, like it is in Ethan's patch. I tried setting it to |
this is the second change yahoo has made in the last few months that treats scripting differently than actual browsers. i fear this api is not long for this world. just my .02 |
Yahoo Finance requires GDPR consent in some countries. We can't automatically consent for the user, so the data request fails with an ambiguous 404 error. Yahoo also started to require a User-Agent in the header. Fixes #392. Fixes #393. Co-authored-by: Ethan Smith <[email protected]>
### Changes in 0.4.25 (2023-08-21) 1. Fix `getQuote.yahoo()` for API changes. Thanks to Ethan B. Smith for the report and patch! Also add error message for users in GDPR countries, since we cannot automatically consent to GDPR and the request fails without consent. [#392](joshuaulrich/quantmod#392) [#393](joshuaulrich/quantmod#393) [#395](joshuaulrich/quantmod#395) 1. Fix `getQuote.yahoo()` when the user only requested metrics that do not have have a value for 'regularMarketTime'. Set the value to NA in these cases so the output remains the same regardless of whether the endpoint returns a 'regularMarketTime' or not. Thanks to @mehdiMBH for the report! [#255](joshuaulrich/quantmod#255) 1. Add fields to `getQuote.yahoo()` that are returned when no fields are explicitly requested. Thanks to @Courvoisier13 for the report! [#335](joshuaulrich/quantmod#335) 1. Add intraday endpoint to `getSymbols.yahoo()`. Thanks to @kapsner for the report and patch! Also allow suppressing the warning if more than 7 days of data are requested (@eddelbuettel). [#351](joshuaulrich/quantmod#351) [#381](joshuaulrich/quantmod#381) [#399](joshuaulrich/quantmod#399) 1. Add warning if `getSymbols()` is called with tickers that are reserved words because accessing them requires back-quotes (e.g. ``NA``). [#401](joshuaulrich/quantmod#401) 1. Fix `allReturns()` when 'subset' is specified. Thanks to @Panagis1980 for the report! [#402](joshuaulrich/quantmod#402) ### Changes in 0.4.24 (2023-07-17) 1. Fix `getSymbols.oanda()` URL. Thanks to @macray76 for the report. [#387](joshuaulrich/quantmod#387) ### Changes in 0.4.23 (2023-06-14) 1. Fix `getQuote.yahoo()` error. Thanks to Ethan B. Smith for the report and patch! [#382](joshuaulrich/quantmod#382) [#383](joshuaulrich/quantmod#383) 1. Add `name` argument to `add_TA()`. Thanks to @SamoPP for the suggestion! [#377](joshuaulrich/quantmod#377) [#205](joshuaulrich/quantmod#205)
Description
getQuote()
is no longer working.Expected behavior
getQuote("SPY")
etc worked but no longer doesMinimal, reproducible example
Session Info
The text was updated successfully, but these errors were encountered: