Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to issues with the double images produced when the FCS system is toward the edges of its range, we have added functionality to produce a MAGMA CSU masks that has been flipped 180 degrees from its original sky PA to reduce the range of the FCS when needed. Two major changes to the MOSFIRE code have been made:
This script has been tested on my local machine with various MAGMA masks and runs without errors, duplicating the input mask with this PA flip, and is indistinguishable from a flipped mask made with MAGMA. It produces a new mask in a specified directory (default is in the directory in which the script is run './') of the name {mask_original_name}_180flip.xml.
The call is:
python flip_CSU_mask_180.py {csu_maskname}.xml {output_directory}
Additional testing will be done on observer masks for funsies.
Formal testing on mosdev recommended as a next step.