Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improvements #122

wants to merge 1 commit into from

Conversation

gngram
Copy link

@gngram gngram commented Jan 20, 2025

  • Removed extra process overhead used for authentication.
  • Removed CPU intensive polling in 'window_pw_wait' thread for status of authentication process.
  • Improved memory management for error/message string received from PAM module.
  • Cleanup previous error/message on lock screen before printing new error/message.
  • Avoid re-authentication using same password if error encountered in first pass.

@gngram
Improvements
e1a1895 
- Removed extra process overhead used for authentication.
- Removed CPU intensive polling in 'window_pw_wait' thread for status of
  authentication process.
- Improved memory management for error/message string received from PAM
  module.
- Cleanup previous error/message on lock screen before printing new
  error/message.
- Avoid reauthentication using same password if error encountered in
  first pass.

Signed-off-by: Ganga Ram <[email protected]>
@jovanlanik
Copy link
Owner

I can't merge these changes. The reason for PAM authentication being done in a child process is to avoid a poorly behaved PAM module crashing the main application.
I'm sure the code could be improved but I don't think this is the correct way to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gngram @jovanlanik