Skip to content

Commit

Permalink
Revert "[AMD] Disable block merging to avoid block argument explosion (
Browse files Browse the repository at this point in the history
…triton-lang#4176)"

This reverts commit cf2ad02
and enables aggresive strategy to enable block merging.
  • Loading branch information
joviliast committed Sep 6, 2024
1 parent e14ee2d commit 24bfa51
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 31 deletions.
27 changes: 0 additions & 27 deletions test/Conversion/amd/amd-convert-builtin-func.mlir

This file was deleted.

5 changes: 1 addition & 4 deletions third_party/amd/lib/TritonAMDGPUToLLVM/BuiltinFuncToLLVM.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,8 @@ struct ConvertBuiltinFuncToLLVM
MLIRContext *context = &getContext();
ModuleOp mod = getOperation();

// Disable block merging because of:
// https://github.com/llvm/llvm-project/issues/63230
// TODO(giuseros): enable block merging once the above ticket is completed
GreedyRewriteConfig config;
config.enableRegionSimplification = GreedySimplifyRegionLevel::Normal;
config.enableRegionSimplification = GreedySimplifyRegionLevel::Aggressive;

RewritePatternSet patterns(context);
patterns.add<CallOpConversion>(context);
Expand Down

0 comments on commit 24bfa51

Please sign in to comment.