♻️ Use includedProperties instead of ignoredProperties #1522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Extending the
Jovo
class with additional properties causedMaximum call stack size exceeded
exceptions in the JovoDebugger if they contained a reference to the jovo object.This PR proposes to change the approach to
includedProperties
instead of ignoring these properties viaignoredProperties
.ignoredProperties
is still available to prevent a breaking change.Best practice if you want to extend the
includedProperties
arrayTypes of Changes
Checklist