Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add VideoAppLaunchOutput for Alexa #1552

Merged

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

Similar to this PR, I created an Output for the VideoApp Interface.

It handles the exclusion of shouldEndSession like the docs and provides an easy way to send a VideoApp output with typed options

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Copy link
Member

@aswetlow aswetlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sadlowskij!

While going through the docs to see if there are any additions needed for this PR (there aren't), I fixed a formatting problem on the Alexa README that has been bugging me for a while

@jankoenig jankoenig changed the title ✨ added VideoAppLaunchOutput for alexa ✨ Add VideoAppLaunchOutput for alexa May 4, 2023
@jankoenig jankoenig changed the title ✨ Add VideoAppLaunchOutput for alexa ✨ Add VideoAppLaunchOutput for Alexa May 4, 2023
@jankoenig jankoenig merged commit 7f865eb into jovotech:v4/dev May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants