Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fixes crash in Dashbot plugin caused by non-JSON responses #1556

Merged
merged 1 commit into from
May 31, 2023

Conversation

palle-k
Copy link
Contributor

@palle-k palle-k commented May 9, 2023

Proposed Changes

We noticed a frequent error coming from the catch block of the DashbotAnalyticsPlugin.
This was apparently caused by 502 Bad Gateway errors returned by Dashbot, which have a HTML formatted body.

This PR introduces safeguards that prevent the catch block from crashing when a non-JSON response is returned by Dashbot.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@jankoenig jankoenig self-requested a review May 31, 2023 08:34
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jankoenig jankoenig merged commit f5e6fdf into jovotech:v4/dev May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants