🐛 Removed source-map-support for ts-jest.

[jBernavaPrah]

Proposed Changes

Fix: #1561

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• [?] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

[jBernavaPrah]

Hi!
This is my first PR here. If I did something wrong let me know :)

Thanks!

[aswetlow]

Hey @jBernavaPrah
Great catch! I had the same issue a few weeks ago but couldn't find a quick fix. I just realized we had a solution for this in v3

jovo-framework/jovo-core/src/index.ts

Line 15 in 56a8ae4

require('source-map-support').install(); // tslint:disable-line

Removing the install part would break stuff. But it will work if it is not used in Jest. Could you update your code?

try {
  // do not use source map support with jest.
  if (process.env.JEST_WORKER_ID === undefined) {
    // eslint-disable-next-line @typescript-eslint/no-var-requires
    require('source-map-support').install(); 
  }
} catch (error) {
  Log.error(error);
}

[jBernavaPrah]

Thanks @aswetlow!

I will do the change you suggested.

I have a concern regarding the try-catch.
I think that is wrong the wrap the code in the try-catch because in any case, as being impossible to install the source-map-support the process needs to fail.

Mainly 3 reasons:

1. You tell that this is necessary for another part of the project.
2. Until now, this was already without the try-catch and “worked”.
3. With only console error, this will not be possible to catch the error in upper statements.

What do you think or what I'm missing here?

[aswetlow]

Sorry, I did a simple copy&paste from the old version. I can't remember why we added the try/catch block, but I think it failed in some environments. It may not be relevant anymore since we didn't have issues with it in v4.

It's a simple error logging in the catch block because it was okay to fail silently.

You can remove the try/catch block.

if (process.env.JEST_WORKER_ID === undefined) {
    // eslint-disable-next-line @typescript-eslint/no-var-requires
    require('source-map-support').install(); 
  }

Thank you for questioning my suggestion.

[jBernavaPrah]

Fix done! :)

Thanks for explaining it @aswetlow!

[jankoenig]

Thank you @jBernavaPrah! 🎉