Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only parse jwk data as json when passing in a string #475

Closed
wants to merge 1 commit into from
Closed

Only parse jwk data as json when passing in a string #475

wants to merge 1 commit into from

Conversation

belak
Copy link

@belak belak commented Feb 21, 2020

This allows a user to request the /.well-known/jwks.json file from a server, parse it, look up the appropriate key, and load it without having to dump the key to json again.

I realize this will be superseded by version 2.0 as that introduces better support for JWKs in general, but this fixes the given use case for us until that releases.

@coveralls
Copy link

coveralls commented Feb 21, 2020

Pull Request Test Coverage Report for Build 149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 132: 0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@belak
Copy link
Author

belak commented Feb 21, 2020

It looks like the only failing build is related to python 3.8 support with PyCrypto (due to time.clock() being removed). It's the same failure as master.

@belak belak requested a review from jpadilla February 21, 2020 21:25
@belak
Copy link
Author

belak commented Apr 8, 2020

This is most likely superceded by #470 which greatly improves on the JWK support.

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label May 29, 2022
@github-actions github-actions bot closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues without activity for more than 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants