make it build on M2 macOS 13 (probably M1 and 10.13) #93
+5
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
However, I can't merge, @jpcima didn't gave me a permission to this repo, and now I can't contact him: he seems disappeared for a while... (After September 2022, he disappeared) |
|
I guess, I'll fork this repo to apply/receive fixes until the wonder happens and @jpcima comes back. |
|
I have my own fork with a handful of improvements and migrations to JUCE7 there. If it's looking easier to maintain I can give you write access and do whatever that does not cost (much). https://github.com/atsushieno/ADLplug-AE/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had been trying to build ADLplug/OPNplug on my M2 mac and managed to get it working, so I would share it here.
There was a drawback in the change set though;
midi_keyboard_ex.h/.ccdoes not compile with the latest clang++ from Xcode toolchains (it fails to resolve the class name atJUCE_DECLARE_NON_COPYABLE_WITH_LEAK_DETECTOR). Looks like it is required only to reducejuce_audio_utils, so I only removed the hack around (exnamespace) and simply added the module to the build as I don't see the reason why it had better be cut. If there is any way to preserve it to still compile fine, then I would bring it back, I do not stick to it.