cli: port from structopt v0.2 to clap v4 #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the update! Merging this in now (resolving some minor conflicts locally) and will try to get a release out shortly. |
jpeddicord
added a commit
that referenced
this pull request
Oct 22, 2024
|
I think I goofed up the commit semantics to get GitHub to recognize that this is merged: it is! Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structopt crate dependency is currently really old (the last release in the v0.2 branch was in 2019). The functionality previously provided by structopt has been merged into clap itself as of v3.
This PR updates askalono-cli from structopt v0.2 to clap v4. I have verified that all CLI options remain the same. Help output is equivalent, except much prettier ✨ thanks to better formatting in recent clap versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.