Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to latest lts in .nvmrc #494

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

Kavinjsir
Copy link
Contributor

Description

Update the node version to the latest lts v16.16.0 in .nvmrc.

Motivation

Keep nodejs version in align with lts.

Relative issue: #490

@vercel
Copy link

vercel bot commented Aug 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
typescript-nextjs-starter ✅ Ready (Inspect) Visit Preview Aug 16, 2022 at 4:26PM (UTC)

.nvmrc Outdated
@@ -1 +1 @@
12.22
16.16.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can put just 16, and it should be better. 16.16.0 is a very recent version, and probably few folks are using it.

Suggested change
16.16.0
16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Make sense! Get updated.

@Kavinjsir Kavinjsir force-pushed the chore/bump-node-version branch from 127ff5d to af433bd Compare August 16, 2022 16:26
@Kavinjsir Kavinjsir changed the title chore: bump to latest lts(16.16.0) in .nvmrc chore: bump to latest lts(v16) in .nvmrc Aug 16, 2022
Copy link
Owner

@jpedroschmitz jpedroschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @Kavinjsir!

@jpedroschmitz jpedroschmitz changed the title chore: bump to latest lts(v16) in .nvmrc chore: bump to latest lts in .nvmrc Aug 16, 2022
@jpedroschmitz jpedroschmitz merged commit 857a09e into jpedroschmitz:main Aug 16, 2022
@Kavinjsir Kavinjsir deleted the chore/bump-node-version branch August 18, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants