Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -v and --verbose flags. #11

Closed
wants to merge 1 commit into from
Closed

Conversation

dhbaird
Copy link

@dhbaird dhbaird commented Nov 16, 2013

No description provided.

@dhbaird dhbaird mentioned this pull request Nov 16, 2013
@jpetazzo
Copy link
Owner

Wouldn't it be easier to use set -x for that?

@bartmeuris
Copy link

To be honest, this seems like a cleaner sollution, set -x becomes very spammy, this shows only the commands pipework executes on purpose...

@jpetazzo
Copy link
Owner

Hi!

  1. Allow to apologize for the slow answer. I appreciate the contribution, just got swamped under things and couldn't answer earlier!
  2. You're right. set -x is too spammy, I like your option better.
  3. I have one suggestion; what do you think about outputting debug info to stderr?
  4. And another one: what about defining a debug() function, and use that when you need to display something (and call it from run())?
  5. Last but not least: if you're willing to rebase (and possibly integrate ideas 3 and 4 since that should be pretty easy :-)) I will be super happy to merge this!

Thanks once again.

@jpetazzo
Copy link
Owner

jpetazzo commented Sep 6, 2015

I'll close this PR, but if somebody wants to work on a similar feature, let me know and reference this one. Thank you!

@jpetazzo jpetazzo closed this Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants