Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working on ci switch to gha / jupyterlab 4 support #162

Closed
wants to merge 1 commit into from
Closed

working on ci switch to gha / jupyterlab 4 support #162

wants to merge 1 commit into from

Conversation

timkpaine
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Binder Launch a binder notebook on branch jpmorganchase/jupyter-fs/tkp/ci

@timkpaine timkpaine force-pushed the tkp/ci branch 3 times, most recently from 75f233c to 9eee0ba Compare May 19, 2023 14:20
vidartf
vidartf reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's in a draft state, but I added some notes.

.bumpversion.cfg Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
js/tsconfig.tsbuildinfo Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
@timkpaine timkpaine changed the title working on ci switch to gha working on ci switch to gha / jupyterlab 4 support May 19, 2023
@timkpaine timkpaine force-pushed the tkp/ci branch 2 times, most recently from 412be89 to 9e83767 Compare May 19, 2023 16:46
@timkpaine
Copy link
Collaborator Author

timkpaine commented May 19, 2023 •
edited
Loading

Status:

  • working on JupyterLab 4.0 (minimal changes, just had to deal with hidden)
  • Linux / Docker based CI seems to be working, moved from explicit invocation of images to using podman-compose to run the docker images all together
  • Having difficulties getting samba running properly on my Mac, but will also test that
  • Need to setup windows share drive testing to match appveyor

@timkpaine timkpaine force-pushed the tkp/ci branch 21 times, most recently from 1b0d98c to c99b8b1 Compare May 20, 2023 01:50
@timkpaine timkpaine force-pushed the tkp/ci branch 2 times, most recently from 12e2d91 to 4d44f4b Compare May 20, 2023 02:11
@github-actions
Copy link

github-actions bot commented May 20, 2023 •
edited
Loading

Test Results

  3 files    5 suites   41s ⏱️
  8 tests   8 ✔️ 0 💤 0 ❌
10 runs  10 ✔️ 0 💤 0 ❌

Results for commit 6b9f28c.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@4865c08). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage        ?   40.51%           
=======================================
  Files           ?       24           
  Lines           ?     1160           
  Branches        ?      145           
=======================================
  Hits            ?      470           
  Misses          ?      647           
  Partials        ?       43

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timkpaine
Copy link
Collaborator Author

timkpaine commented May 20, 2023 •
edited
Loading

someone with admin will need to adjust the expected status checks, I think the appveyor builds are no longer running and we'll want to switch over to the GHA build once this is merged.

Also if someone could take care of the codecov integration above (@jpmtrm)

@timkpaine timkpaine marked this pull request as ready for review May 22, 2023 12:34
@vidartf
Copy link
Contributor

vidartf commented May 24, 2023

I appreciate the work here! Could we split the lab 4 update into a separate PR? We have a bunch of changes that we plan to merge and release against 3.x, and it would be great to have CI for those.

@krassowski krassowski mentioned this pull request May 24, 2023
Open
@timkpaine timkpaine mentioned this pull request May 30, 2023
Merged
@timkpaine
Copy link
Collaborator Author

rebase on #165 when merged

@timkpaine timkpaine marked this pull request as draft May 30, 2023 20:14
@timkpaine
Copy link
Collaborator Author

jupyterlab/jupyterlab#14590

@t3rryM t3rryM marked this pull request as ready for review July 26, 2023 01:39
@t3rryM t3rryM requested a review from a team as a code owner July 26, 2023 01:39
@timkpaine timkpaine mentioned this pull request Aug 13, 2023
Merged
@fcollonval fcollonval mentioned this pull request Aug 15, 2023
Open
@timkpaine
Copy link
Collaborator Author

done in #174

@timkpaine timkpaine closed this Oct 10, 2023
@timkpaine timkpaine deleted the tkp/ci branch October 10, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3rryM t3rryM t3rryM approved these changes

@vidartf vidartf Awaiting requested review from vidartf

@telamonian telamonian Awaiting requested review from telamonian

@ceball ceball Awaiting requested review from ceball

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkpaine @codecov-commenter @vidartf @t3rryM