Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve concurrent mode testing #294

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Improve concurrent mode testing #294

merged 2 commits into from
Aug 17, 2022

Conversation

joshwooding
Copy link
Contributor

@joshwooding joshwooding commented Aug 3, 2022 •
edited
Loading

Use Cypress' React 18 concurrent mode testing

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4bde18c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 3, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bde18c
Status: ✅  Deploy successful!
Preview URL: https://e3a7b350.uitk.pages.dev
Branch Preview URL: https://improve-concurrent-mode-test.uitk.pages.dev

View logs

@joshwooding
Copy link
Contributor Author

joshwooding commented Aug 3, 2022 •
edited
Loading

Blocked by cypress-io/cypress#23081

@joshwooding joshwooding marked this pull request as draft August 3, 2022 22:47
@joshwooding joshwooding force-pushed the improve-concurrent-mode-testing branch 7 times, most recently from 131851f to 5ddf56d Compare August 16, 2022 23:13
@joshwooding joshwooding marked this pull request as ready for review August 16, 2022 23:13
@joshwooding joshwooding force-pushed the improve-concurrent-mode-testing branch from 5ddf56d to be613ac Compare August 17, 2022 11:24
@joshwooding joshwooding force-pushed the improve-concurrent-mode-testing branch from be613ac to 4bde18c Compare August 17, 2022 14:31
ZarkoPernar
ZarkoPernar approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@ZarkoPernar ZarkoPernar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking G

@joshwooding joshwooding merged commit 0a2a165 into main Aug 17, 2022
@joshwooding joshwooding deleted the improve-concurrent-mode-testing branch August 17, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZarkoPernar ZarkoPernar ZarkoPernar approved these changes

@origami-z origami-z Awaiting requested review from origami-z

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @ZarkoPernar