Min / Max rules that are set to a value of 0 are now included in the rul... #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rule set for an element.
|
Thank you for the contribution! Could you update this to allow |
Changed the rule test to make an exception for zero or the rule itself.
|
Thanks ruben-j for the better solution. I have created a new commit implementing the recommendation. |
|
Thanks, this looks good. Would be even better with a unit test, to prevent regressions. |
|
Also close #854 when landing this. |
|
Jörn, What do you mean by "landing this"? |
|
"landing this" means merging the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the defect. The min & max rules now support having a value of 0 as the rule.