optimize by lint

jrfeng · Sep 19, 2020 · 8c9f4d4 · 8c9f4d4
1 parent 302ea9d
commit 8c9f4d4
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/player/src/main/java/snow/player/PlayerClient.java b/player/src/main/java/snow/player/PlayerClient.java
@@ -10,7 +10,6 @@
 import android.os.RemoteException;
 import android.support.v4.media.MediaBrowserCompat;
 import android.support.v4.media.session.MediaControllerCompat;
-import android.util.Log;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;

diff --git a/player/src/main/java/snow/player/PlayerService.java b/player/src/main/java/snow/player/PlayerService.java
@@ -69,6 +69,7 @@
  * 因为本项目大部的功能都依赖于 {@link PlayerClient} 类，如果不使用 {@link PlayerClient} 类，那么也无法使
  * 用这些功能。
  */
+@SuppressWarnings("SameReturnValue")
 public class PlayerService extends MediaBrowserServiceCompat implements PlayerManager {
     /**
      * 默认的 root id，值为 `"root"`。
@@ -1096,6 +1097,7 @@ protected void onInit(Context context) {
         /**
          * 该方法会在 Service 销毁时调用，可以在该方法中释放占用的资源。
          */
+        @SuppressWarnings("EmptyMethod")
         protected void onRelease() {
         }
 

diff --git a/player/src/main/java/snow/player/PlaylistManagerImp.java b/player/src/main/java/snow/player/PlaylistManagerImp.java
@@ -2,10 +2,8 @@
 
 import android.annotation.SuppressLint;
 import android.content.Context;
-import android.util.Log;
 
 import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
 
 import com.google.common.base.Preconditions;
 import com.tencent.mmkv.MMKV;
@@ -21,7 +19,6 @@
 import io.reactivex.schedulers.Schedulers;
 import snow.player.audio.MusicItem;
 import snow.player.playlist.Playlist;
-import snow.player.playlist.PlaylistEditor;
 import snow.player.playlist.PlaylistManager;
 
 /**
@@ -67,6 +64,7 @@ public int getPlaylistSize() {
         return mMMKV.decodeInt(KEY_PLAYLIST_SIZE, 0);
     }
 
+    @SuppressWarnings("ResultOfMethodCallIgnored")
     @SuppressLint("CheckResult")
     @Override
     public void getPlaylist(@NonNull final Callback callback) {

diff --git a/player/src/main/res/values/dimens.xml b/player/src/main/res/values/dimens.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <dimen name="snow_notif_icon_size_big">96dp</dimen>
-    <dimen name="snow_notif_icon_corner_radius">8dp</dimen>
 
 </resources>