Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement query and hash resolution #114

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Implement query and hash resolution #114

merged 2 commits into from
Jul 5, 2022

Conversation

jridgewell
Copy link
Owner

This allows the ?query and #hash component to resolve. The rules are simple enough:

  1. If input has a scheme, host, path, or query, then
    1. Keep input's query and hash.
  2. Else,
    1. If input does not have a hash, inherit base's hash
    2. Inherit base's query

Fixes #113

@jridgewell jridgewell merged commit 68f9782 into main Jul 5, 2022
@jridgewell jridgewell deleted the query-or-hash branch July 5, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query params need to be propagated
1 participant