Add support for MathJax 3, upgrade vendored MathJax to 3.2.2 #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
approved these changes
Jan 22, 2025
ManifoldFR
force-pushed
the
topic/doxygen-mathjax-2025
branch
4 times, most recently
from
be473e5 to
3ed3531
Compare
…. Print status message in that case.
…ed version doxygen.cmake : update copyright year doxygen.cmake : only set default mathjax relpath if mathjax 3
ManifoldFR
force-pushed
the
topic/doxygen-mathjax-2025
branch
from
3ed3531 to
42213fd
Compare
ManifoldFR
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #737 and #738
This pull request updates the vendored files for MathJax to the latest release, 3.2.2.
The previous version that was shipped with jrl-cmakemodules was from an old 2.x from over a decade ago. MathJax 3.x is a full rewrite which is much faster than 2.x (partly as a response to the development of KaTeX which was leaner and faster).
Major changes
MATHJAX_VERSION, which defaults toMathJax_3(for Doxygen>=1.9.2. Other users get MathJax 2.)MATHJAX_RELPATHis set to${PROJECT_JRL_CMAKE_MODULE_DIR}/doxygen/MathJax(i.e. our vendored MathJax). If the user desires MathJax 2, they can set the path themselves, or leave it unset to let Doxygen inject the MathJax 2.x CDN instead.doxygen/MathJaxto the pre-commit exclusion rules.