-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.9 build testing #1018
Conversation
This still needs some work. Issues to figure out:
To anyone looking at this: feel free to offer thoughts and suggestions. I'll come back to this later this week. |
Yeah, the sed command was a hack thrown in there when we didn't have to consider the other OSes. We should probably use the toml library we already load in our python dev deps. |
…, and remove extraneous unused python key
…Python 3.9 executable is
I've resolved the I'll come back to this later but, as always, any help is appreciated. |
Okay. I think this is about as good as I'm going to get this. Windows is correctly using Python 3.9, but it can't install cryptography because there are no wheels available for Python 3.9. The alternative is building it from source, which feels like a bit much, and isn't very representative of Windows users anyway, as they are generally not going to take this approach.. Maybe it will work as we get closer to the release in October, or if not, we'll at least know about this issue when we cross that bridge. |
.travis.yml
Outdated
# ... and beyond! | ||
- name: Python nightly on Linux | ||
before_install: | ||
- sed -i 's/^python = ">=3\.6\.0.*"$/python = "*"/' pyproject.toml | ||
- sed -i 's/^python = ">=3\.7\.0.*"$/python = "*"/' pyproject.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use your new script ( .build/allow_all_python_version.py
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great with one minor comment. I'll be happy to merge if you don't want to fix it, just let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐆
* First stab at adding Python 3.9 dev Travis builds * Dynamically replace Python max version for Python 3.9 beta builds * Fix allow_failures (3.9-dev, not 3.9) and fix Windows find-and-replace command to allow 3.9 * Fix allow_failures to allow all three Python 3.9 builds to fail * Use platform-independent Python script to allow all Python versions for 3.9 builds * Format changes and changing before_install to script for 3.9 builds * Install toml module to make it possible to run version-changing script before install * Properly populate before_install step with Mac and Windows Python 3.9, and remove extraneous unused python key * Add refreshenv to get python3 path included in WIndows * Ensure MacOS pyenv is up to date and attempt to reference Windows python3 directly * Use bash-friendly paths in Windows and check to see exactly what the Python 3.9 executable is * Confirm Python version in Windows and attempt to get pip a different way * Fiddling with Windows python references * Remove Python3.6 references and check for Python directory in root directory * Add Python 3.9 path to Windows build * Remove pip steps that should be unnecessary * Add upgrade pip to Windows Python 3.9 build * Attempt to resolve "access denied" error when upgrading pip on Windows * Use allow_all_python_version TOML script in nightly build instead of sed
First step of #1017 - add build steps for Python 3.9 in Travis. Allowing failures for now, until 3.9 is stable.
Checklist
for the same issue.