Check for readline module instead of Windows when initializing autocomplete in install #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplete in install
This comment has been minimized.
This comment has been minimized.
Unit Test Results 16 files 16 suites 10s ⏱️ results for commit 48cde1b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1015 and should now prevent crashes on install for ActivePython users that aren't on Windows. We haven't seen this
readlineissue as much lately, and unfortunately I can't reproduce every environment in which it happens, but this should hopefully mitigate the problem further, and the unit test offers some peace of mind.Checklist
for the same issue.