Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lone closing parenthesis #1118

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Fix lone closing parenthesis #1118

merged 1 commit into from
Dec 16, 2020

Conversation

maebert
Copy link
Contributor

@maebert maebert commented Dec 15, 2020 •
edited
Loading

Look, this might me my least ambitious commit ever, but having mismatched parentheses has crashed the internet before, so let's rather be safe than sorry!

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have tested this code locally.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.
  • All tests pass.

@maebert
Fixes lone closing parenthesis in docs
736e329 
Look, this might me my least ambitious commit ever, but having mismatched parentheses has crashed the internet before, so let's rather be safe than sorry!
@github-actions

This comment has been minimized.

Sign in to view
wren
wren approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, we wouldn't want to crash the internet.

Thank you!

@wren wren merged commit e03021a into jrnl-org:develop Dec 16, 2020
@wren wren added the documentation Improvements or additions to documentation label Dec 16, 2020
@wren wren changed the title Fixes lone closing parenthesis in docs Fix lone closing parenthesis Dec 16, 2020
@github-actions
Copy link

Unit Test Results

  9 files  9 suites   0s ⏱️
49 tests 0 ✔️ 0 💤 49 ❌

results for commit e03021a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maebert @wren