-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test suite to Pytest (replace Behave) #1193
Conversation
8bd89b7
to
7bacf4a
Compare
9eb9990
to
f50b430
Compare
ea37d4b
to
50c053c
Compare
I'm getting some IO and recursion errors while running these on Windows. These repeats a ton:
And at the end, I get:
|
As a headsup, I discovered today that the current behave test suite does not run as expected (at all?) if not run from the project root folder. |
Let's move off of pyflakes, probably to pylint, maaaaybe to flake8, though pylint looks better at first glance. |
- Implement mock editor fixture - Add fixture to keep track of editor state - Implement various steps to check editor state Co-authored-by: Micah Jerome Ellison <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
Co-authored-by: Micah Jerome Ellison <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
Co-authored-by: Micah Jerome Ellison <[email protected]>
Co-authored-by: Micah Jerome Ellison <[email protected]>
Co-authored-by: Micah Jerome Ellison <[email protected]>
- This was awful and convoluted Co-authored-by: Micah Jerome Ellison <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
- Take out old steps from format and input tests Co-authored-by: Micah Jerome Ellison <[email protected]>
- Run formatter - Take out old tags - Use new steps on tests Co-authored-by: Micah Jerome Ellison <[email protected]>
- Take out old type coersion (it was causing needles complexity) - Take out `read_value_from_string` function - Use taml parser to parse yaml instead of using custom function - Update tests to use new implementation Co-authored-by: Micah Jerome Ellison <[email protected]>
- Misc linting issues - Whitespace cleanup - Entire test suite is now passing - Add misc todo items in comments Co-authored-by: Micah Jerome Ellison <[email protected]>
- Fix failing DayOne test - Make format and clean up extraneous comment Co-authored-by: Jonathan Wren <[email protected]>
Co-authored-by: Jonathan Wren <[email protected]>
Now that all the tests are passing, this breaks them up into a few different files to make everything more organized. Note: Pyflakes is complaining about some unused import statements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪
Fixes #1192
Moves test suite entirely into pytest from behave.