Add bdd tests for jrnl installation #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/bdd/features/install.feature
Outdated
Comment on lines
6
to
7
| | | ||
| | |
There was a problem hiding this comment.
Could you use \n for this instead of a pipe? I think that will be a bit more Gherkin-appropriate since the Gherkin reference has some allowances for this inside of table cells already.
There was a problem hiding this comment.
Yeah, I can do that. I can see how that might be confusing.
|
@apainintheneck Hey, this PR is looking good so far; we just need a little more time to review (had a lot of PRs today, and focusing on the beta). We'll come back to this next week and get merged in. Thank you! |
apainintheneck
force-pushed
the
install-tests
branch
from
9d5a574 to
3d29514
Compare
micahellison
requested changes
Jun 25, 2022
micahellison
approved these changes
Jun 25, 2022
micahellison
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
for the same issue.
This is just a first stab at adding BDD tests related to installation as mentioned in #1473. I couldn't really find a way to make it work with just Gherkin because of some of the required mocking and steps that were added. Is that sorta what you had in mind?
The biggest change I made was to use the pipe character
|as the equivalent of an empty line of input in theall_inputsfixture used by thewhen_steps.we_run_jrnl()method. This change made it a lot easier to test the default journal installation case and I think it makes the BDD test more readable too. Do you all know of a better way to handle that?Resolves #1473.