Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tzlocal to v4.x and remove pytz dependency #1528

Merged
merged 7 commits into from
Jul 30, 2022

Conversation

outa
Copy link
Contributor

@outa outa commented Jul 3, 2022

Changes

Caveats

There are some differences between pytz's is_dst and datetime's fold argument: https://pytz-deprecation-shim.readthedocs.io/en/latest/migration.html#semantic-differences-between-is-dst-and-fold

I had to adapt a test for this. I don't know what the implications of this would be for jrnl. Please decide if this is reasonable for you.

Closes: #1338

Checklist

  • I have read the contributing doc.
  • I have included a link to the relevant issue number.
  • I have checked to ensure there aren't other open pull requests
    for the same issue.
  • I have written new tests for these changes, as needed.

Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @outa, thank you for working on this! I just merged the develop branch in after our 3.0 release to update the poetry.lock file, and I still see a couple issues in the Mac tests on this PR. Let us know if you have any questions about those or would like any help.

@outa
Copy link
Contributor Author

outa commented Jul 14, 2022

Hi Micah! So after you merged the develop branch, the tests were failing on my laptop (using Ubuntu). However in the Gitlab pipeline they passed for some reason. I think we are running into this issue: regebro/tzlocal#131

I am trying to work around that now. However debugging the macOS tests is a bit difficult for me, because I don't have access to a macOS machine. Is there some way to test in a mac environment before pushing changes?

wren
wren previously approved these changes Jul 16, 2022
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a tricky one, but you nailed it. Thank you!

micahellison
micahellison previously approved these changes Jul 16, 2022
@wren wren dismissed stale reviews from micahellison and themself via 39e4be9 July 30, 2022 19:13
@wren wren merged commit 62f65ce into jrnl-org:develop Jul 30, 2022
@wren wren added enhancement New feature or request build Issues related to the build pipeline packaging Updates to packaging (dependencies, etc) and removed build Issues related to the build pipeline labels Jul 30, 2022
@micahellison micahellison mentioned this pull request Aug 13, 2022
11 tasks
@outa outa deleted the update-tzlocal branch January 8, 2023 08:52
minchinweb added a commit to minchinweb/minchin.jrnl that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging Updates to packaging (dependencies, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tzlocal v4
3 participants