Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent readline usage on Windows, which was causing Active Python crashes on install #751

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Prevent readline usage on Windows, which was causing Active Python crashes on install #751

merged 1 commit into from
Nov 26, 2019

Conversation

micahellison
Copy link
Member

This removes autocomplete for Windows users, thus preventing jrnl from crashing on Active Python, which has no readline module. It's only used when entering the path on the install step.

Related issue: #738

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • [n/a] Have you written new tests for your core changes, as applicable?

@wren wren added bug Something isn't working windows labels Nov 19, 2019
@wren wren changed the base branch from master to develop November 26, 2019 04:42
@micahellison micahellison added this to the v2.1.1 - Doctor's Orders milestone Nov 26, 2019
wren
wren approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@wren wren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎐

@wren wren merged commit 0c1b577 into jrnl-org:develop Nov 26, 2019
@micahellison micahellison changed the title [GH-738] preventing readline usage on Windows Prevent readline usage on Windows, which was causing Active Python crashes on install Jan 11, 2020
@lock
Copy link

lock bot commented May 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the 🔒 Outdated label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wren wren wren approved these changes

Assignees
No one assigned
Labels
bug Something isn't working 🔒 Outdated windows
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@micahellison @wren