Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Poetry requirements for testing latest Python version #898

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

wren
Copy link
Member

@wren wren commented Mar 28, 2020

Fixes #870

Poetry errors out if we try to run a different version of Python that
what is specified in the config file. We want to run tests against the
latest Python version so we can see problems before they happen. This
fix updates the config file so Poetry will allow us to test. Nothing is
committed after the update.

Checklist

  • The code change is tested and works locally.
  • Tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?

Poetry errors out if we try to run a different version of Python that
what is specified in the config file. We want to run tests against the
latest Python version so we can see problems before they happen. This
fix updates the config file so Poetry will allow us to test. Nothing is
committed after the update.
@wren wren force-pushed the udpate-nightly-tests-870 branch from 7ec279a to 25d800d Compare March 28, 2020 23:21
@wren
Copy link
Member Author

wren commented Mar 28, 2020

Please note that the latest python version tests are still failing (due to a different issue). But with this PR, they are at least running again.

@wren wren added the build Issues related to the build pipeline label Mar 28, 2020
Copy link
Member

@micahellison micahellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahellison micahellison merged commit 8284c90 into jrnl-org:develop Apr 1, 2020
@wren wren deleted the udpate-nightly-tests-870 branch April 1, 2020 05:33
wren added a commit that referenced this pull request Apr 18, 2020
Poetry errors out if we try to run a different version of Python that
what is specified in the config file. We want to run tests against the
latest Python version so we can see problems before they happen. This
fix updates the config file so Poetry will allow us to test. Nothing is
committed after the update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to the build pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python nightly build doesn't actually test jrnl against latest Python version
2 participants