Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable --delete due to critical bug #934

Merged
merged 1 commit into from
May 2, 2020
Merged

Disable --delete due to critical bug #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/delete.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Feature: Delete entries from journal

@skip
Scenario: --delete flag allows deletion of single entry
Given we use the config "deletion.yaml"
When we run "jrnl -n 1"
Expand Down
18 changes: 12 additions & 6 deletions jrnl/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,14 @@ def parse_args(args=None):
action="store_true",
)

exporting.add_argument(
"--delete",
dest="delete",
action="store_true",
help="Opens an interactive interface for deleting entries.",
)
# Disabling this momentarily due to critical bug
# @see https://github.com/jrnl-org/jrnl/issues/932
# exporting.add_argument(
# "--delete",
# dest="delete",
# action="store_true",
# help="Opens an interactive interface for deleting entries.",
# )

# Handle '-123' as a shortcut for '-n 123'
num = re.compile(r"^-(\d+)$")
Expand Down Expand Up @@ -301,6 +303,10 @@ def configure_logger(debug=False):

def run(manual_args=None):
args = parse_args(manual_args)

# temporary until bring back --delete
args.delete = False # TODO: remove me

configure_logger(args.debug)
if args.version:
version_str = f"{jrnl.__title__} version {jrnl.__version__}"
Expand Down