Make sure testing cleans up after itself #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to run commands in a cache directory without the test writer knowing where the cache directory is located. This will let us expand later if we want to start using system temp folders, without having to rewrite any of our tests.
wren
force-pushed
the
clean-testing-leftovers
branch
from
7e9d10a to
83547ac
Compare
|
Welp, Windows is failing for unknown (to me) reasons. @micahellison Would you mind taking a look at this? |
Co-authored-by: Micah Jerome Ellison <[email protected]>
wren
added a commit
that referenced
this pull request
Jul 25, 2020
This adds the ability to run commands in a cache directory without the test writer knowing where the cache directory is located. This will let us expand later if we want to start using system temp folders, without having to rewrite any of our tests. * clean up extra directories after running behave * clean up white space issues * move repeated code into function * clean up behave code for creating cache directories * Fix for windows shell parsing in our test suite Co-authored-by: Micah Jerome Ellison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #939
This centralizes where we store all of our testing temporary files (in
featuresfor now, but can easily be moved later), and cleans that centrallocation properly. This should result in a clean working directory after
running the testing suite.
Checklist
poetry run behaveblack (consistent code styling). --
poetry run black --check . --verbose --diff(logically errors and unused imports). --
poetry run pyflakes jrnl featuresPull Requests for the same update/change?
us to include them?