Better sync with ActiveRecord attributes; removal of AttrJson::Record::Dirty #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except using standard rails dirty tracking now. Just being sure it's good.
We sync rails attributes better, to use standard rails dirty tracking. Our own custom dirty tracking was actually pretty badly broken anyhow, ref #148
jrochkind
added a commit
that referenced
this pull request
Dec 22, 2022
This was referenced Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we sync better, we can get dirty tracking mostly working. So we can remove our buggy custom
AttrJson::Record::Dirtydirty tracking. That feature will be gone in attr_json 2.0 (It was pretty broken, see AttrJson::Record::Dirty: #will_save_change_to returns true when other attribute was changed #148)We have a test suite verifying ActiveRecord dirty tracking is working, even with in-place mutations.
In process, we noticed that
AttrJson::Type::Arraywas not properly tracking mutation changes in place. Fixed that.