Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closer compat to ActiveModel conventions #169

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Closer compat to ActiveModel conventions #169

merged 4 commits into from
Jan 5, 2023

Conversation

jrochkind
Copy link
Owner

While we're still not using ActiveModel::Attributes, let's make it look even closer in ways we identified.

  • AttrJson::Model#dup properly deep-dups attributes
  • AttrJson::Model#freeze like ActiveModel::Attributes#freeze
  • ActiveModel::Attributes compat methods: .attribute_types ; .attribute_names ; #attribute_names

@jrochkind jrochkind mentioned this pull request Jan 5, 2023
Closed
@jrochkind jrochkind merged commit eb4c4b4 into master Jan 5, 2023
@jrochkind jrochkind deleted the model_dup branch January 5, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jrochkind