Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Need help] Make Feature#properties generic #19

Closed
wants to merge 6 commits into from
Closed

[Need help] Make Feature#properties generic #19

wants to merge 6 commits into from

Conversation

guizmaii
Copy link

@guizmaii guizmaii commented May 29, 2017

It compiles but I'm unfortunately not able to make tests pass.
I don't know how to manage the case where GeoJson can be GeoJson[C] and in the same time GeoJson[C, P]. My Scala skill stops here 😕

@guizmaii guizmaii changed the title Make Feature#properties generic WIP - Make Feature#properties generic May 29, 2017
@guizmaii guizmaii changed the title WIP - Make Feature#properties generic [Need help] Make Feature#properties generic May 29, 2017
@muuki88
Copy link
Contributor

muuki88 commented May 31, 2017

Thanks for taking the time to improve this library 😃

Not the tests, but the test compilation fails. I spotted two
issues

  1. No format found: to read/write your new generic property type P you need an implicit format in scope, which seems not to be the case
  2. Diverging implicit expansion: the Scala compiler has problems finding a single applicable Format instance.

I'm currently on mobile. Hopefully I find some time to checkout your code a give some more help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants