Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rndmh3ro namespace get job with tests #121

Merged
merged 8 commits into from
Aug 31, 2021

Conversation

jrxFive
Copy link
Owner

@jrxFive jrxFive commented Aug 30, 2021

Namespace override for get_jobs

Add tests for #119. Addresses #118.

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #121 (0cadab0) into master (1cc1077) will decrease coverage by 0.04%.
The diff coverage is 87.50%.

❗ Current head 0cadab0 differs from pull request most recent head e8c4c55. Consider uploading reports for the commit e8c4c55 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   90.61%   90.56%   -0.05%     
==========================================
  Files          26       26              
  Lines        1065     1070       +5     
==========================================
+ Hits          965      969       +4     
- Misses        100      101       +1     
Impacted Files Coverage Δ
nomad/api/job.py 93.24% <80.00%> (-1.13%) ⬇️
nomad/api/jobs.py 90.00% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cc1077...e8c4c55. Read the comment docs.

@jrxFive jrxFive merged commit 100e68b into master Aug 31, 2021
@jrxFive jrxFive deleted the rndmh3ro-namespace_get_job_with_tests branch September 1, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants