-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret backend integration with Vault. #83
Open
pserranoa
wants to merge
14
commits into
jrxFive:master
Choose a base branch
from
pserranoa:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5 and 0.5.6. From nomad changelog.md
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 91.19% 91.17% -0.02%
==========================================
Files 26 26
Lines 1033 1042 +9
==========================================
+ Hits 942 950 +8
- Misses 91 92 +1
Continue to review full report at Codecov.
|
…5 and 0.5.6. From nomad changelog.md
Hi @jrxFive , did you have time to analize this pull request? This make sense for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you are working with vault as your secret backed, and you wish to *ensure vault security, you must enable the following parameter at your configuration: https://www.nomadproject.io/docs/configuration/vault.html#allow_unauthenticated
At this pull request, I have tryed to make the following task:
Unify travis and vagrant configuration of nomad and vault daemons using one file. start_daemons.sh
Configure travis to execute several test with diferent version of vault product. Vault has 2 diferentes types of backends: (simple secrets and versioned secrets)
I writed documentation about vault and nomad integration with several samples.
I writed diferents test with a container that publish a secret stored at vault to validate the integration.
I hope you can review and analyse if this pull request could be at your project as part of it
Best regards