Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret backend integration with Vault. #83

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

pserranoa
Copy link
Contributor

if you are working with vault as your secret backed, and you wish to *ensure vault security, you must enable the following parameter at your configuration: https://www.nomadproject.io/docs/configuration/vault.html#allow_unauthenticated

At this pull request, I have tryed to make the following task:

  • Unify travis and vagrant configuration of nomad and vault daemons using one file. start_daemons.sh

  • Configure travis to execute several test with diferent version of vault product. Vault has 2 diferentes types of backends: (simple secrets and versioned secrets)

  • I writed documentation about vault and nomad integration with several samples.

  • I writed diferents test with a container that publish a secret stored at vault to validate the integration.

I hope you can review and analyse if this pull request could be at your project as part of it

Best regards

@codecov-io
Copy link

codecov-io commented Nov 11, 2018

Codecov Report

Merging #83 into master will decrease coverage by 0.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.02%     
==========================================
  Files          26       26              
  Lines        1033     1042       +9     
==========================================
+ Hits          942      950       +8     
- Misses         91       92       +1
Impacted Files Coverage Δ
nomad/api/base.py 97.7% <100%> (+0.17%) ⬆️
nomad/__init__.py 96.8% <66.66%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3eb383...0f8dd9d. Read the comment docs.

@pserranoa
Copy link
Contributor Author

Hi @jrxFive , did you have time to analize this pull request? This make sense for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants