Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astro-reactive.js.org #8630

Merged
merged 4 commits into from
Nov 11, 2023
Merged

astro-reactive.js.org #8630

merged 4 commits into from
Nov 11, 2023

Conversation

ayoayco
Copy link
Contributor

@ayoayco ayoayco commented Nov 11, 2023

@ayoayco
Copy link
Contributor Author

ayoayco commented Nov 11, 2023

Hi! Thanks for this amazing service. First time to request hosting here, so please let me know if I missed anything.🙏

The website used to be in astro-reactive.dev and also has a documentation site in the subdomain docs.astro-reactive.dev -- I was wondering if a subdomain is also possible with js.org?

@indus indus changed the title add: astro-reactive astro-reactive.js.org Nov 11, 2023
@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Nov 11, 2023
@indus
Copy link
Member

indus commented Nov 11, 2023

I've just added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

Regarding your other question - Yes you can just open a new PR for "docs.astro-reactive.js.org". The only difference is that we can't provide SSL (https://) for those sub-subdomains. But I would guess that netlify has an option for this. Or you go for docs-astro-reactive.js.org?!

@indus indus added the question label Nov 11, 2023
@indus
Copy link
Member

indus commented Nov 11, 2023

Looks like your added record has to be placed after "astro" (ln 234) to keep the alphabetical order: https://github.com/js-org/js.org/actions/runs/6834566450/job/18589672360?pr=8630

@ayoayco
Copy link
Contributor Author

ayoayco commented Nov 11, 2023

I'll fix in a bit!

@ayoayco
Copy link
Contributor Author

ayoayco commented Nov 11, 2023

Fixed the order in cnames_active.js file and configured Netlify to accept the custom domain. astro-reactive.js.org is live! 🎉

Regarding my docs site, I will try to put it in a /docs first. Thanks for accommodating my request and answering my question! 🙏

@indus indus removed the question label Nov 11, 2023
@indus
Copy link
Member

indus commented Nov 11, 2023

@indus indus merged commit ef34245 into js-org:master Nov 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants