Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PFRecHit validation; add Alpaka PFRecHit to legacy format conversion; performance optimisations #28

Merged
merged 14 commits into from
Jul 25, 2023
Merged

Fix PFRecHit validation; add Alpaka PFRecHit to legacy format conversion; performance optimisations #28

merged 14 commits into from
Jul 25, 2023

Conversation

fllor
Copy link

@fllor fllor commented Jul 25, 2023 •
edited
Loading

New commits:

  • make PFRecHit validation independent of ordering, such that legacy <-> Alpaka validation succeeds
  • add Alpaka PFRecHit to legacy format conversion
  • add legacy <-> legacy-from-Alpaka validation
  • add Alpaka <-> legacy-from-Alpaka validation
  • (commented out: add legacy <-> legacy-from-CUDA validation, using the legacy PFRecHits that are created by the CUDA module)

Commits from Hackathon that are included here for some reason:

  • optimise performance Alpaka PFRecHitProducer on GPU
  • add configuration that stores HCAL recHits to Root file
  • add configuration that constructs PFRecHits based on said file (preparation for benchmarking)

fllor added 14 commits June 29, 2023 14:03
@fllor
Make Alpaka PFRecHitProducer more parallel
4f2a176
@fllor
Replace outdated data file
20b2fe8
@fllor
Add configuration to store HCAL recHits to file and second configurat…
29fc3e2 
…ion to read that file and run only PFRecHitProducer
@fllor
Optimise kernel layout for CPU backend
49476c6
@fllor
Add ability to use uncompressed data files and run multiple iteration…
9811289 
…s of modules (for benchmarking)
@fllor
Adopt CUDA convention for Alpaka PFRecHits
95183a3
@fllor
Simplify PFRecHit Alpaka vs legacy comparison and make test more rigo…
36f774e 
…rous
@fllor
Merge remote-tracking branch 'jsamudio/tmpPFonGPU' into PFRecHitAndCl…
5802bee 
…uster_GPU_13_0_8
@fllor
Add conversion from Alpaka PFRecHits to legacy format
ede2621
@fllor
Allow more flexible comparisons in PFRecHit validation module
a731f4b
@fllor
Make debug flags of PFRecHit validation accessible via config
5bc5435
@fllor
Make PFRecHit validation insensitive to order again
0e1bff4
@fllor
Make debug flag accessible via command line
80dbcdf
@fllor
Try to validate legacy PFRecHits constructed from CUDA module
925663c
@jsamudio
Copy link
Owner

Can you just write a brief description of the change and the validation done?

@fllor
Copy link
Author

fllor commented Jul 25, 2023

Done

@jsamudio jsamudio merged commit d184815 into jsamudio:tmpPFonGPU Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fllor @jsamudio