updates to dart 2.1 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey David, thank you so much for this! It looks good to me, I just have one question and then we'll probably be able to merge it 😃 |
|
Oh, I didn't realize my second commit will go to this pull request... But it still should be ok, I tested it. |
|
Hi! any plans for merge this? |
You can use my fork as a dependency, if needed. dependencies:
tmdb:
git:
url: [email protected]:ariedov/dart-tmdb.git |
|
will this be merged enventually? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the TMDB API is still the same and the library is still suitable, it is just not ready for dart 2.1.
So here is the bumped up the dart env and fixed compilation errors.