Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix over double quotation symbol (") #381

Closed
wants to merge 5 commits into from
Closed

Conversation

hassadee
Copy link

Fix over double quotation symbol (") at "autoreload" ID at line 170

Hassadee Pimsuwan and others added 4 commits April 21, 2018 13:32
Update to latest version of OpenJSCAD
Fix web's example path.
Change part back to ./ and copy ../examples to ./examples in web/ directory instaed of ../examples
Fix over double quotation symbol.
@z3dev
Copy link
Member

z3dev commented Apr 22, 2018

Ummm... you changed every single line in the HTML file. How are we suppose to know what changed?

Two options.
1 Supply the lines numbers of the changes
2 Create a new PR with just the changes to those lines

I would prefer option 2

@hassadee
Copy link
Author

Sorry for modify tab indent in every single line of the HTML file.

The line number of the change is 170

@z3dev
Copy link
Member

z3dev commented Apr 23, 2018

Thanks. I saw that change, but was concerned about others.

Will take a serious look now.

@z3dev
Copy link
Member

z3dev commented Apr 23, 2018

A few comments...

You need to respect the intention of each file. We don’t use 4 space intention. Please use 2 space intention, and update the files again.

Second, if this PR is for the Thai language support then change the name, and description.

@hassadee
Copy link
Author

Hmm, I use 2 space for tab indent in Visual Studio Code, don't know why its appear as 4 space indent here. I think I will create new PR instead.

@hassadee hassadee closed this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants