Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 STL Deserializer #466

Merged
merged 21 commits into from
Dec 17, 2019
Merged

V2 STL Deserializer #466

merged 21 commits into from
Dec 17, 2019

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Sep 4, 2019 •
edited
Loading

This pull request updates the STL deserializer to use CSG V2 API, as well as translate to CSG V2 API. The goals of this pull request are:

  • Update to use CSG V2 API
  • Update code up to JSCAD coding standards
  • Add test suites to complete coverage, 93.63%

New Features:

  • support for colors

Fixes jscad/io#8
Fixes jscad/io#53

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

z3dev added 16 commits September 4, 2019 11:01
@z3dev
fix(stl-deserializer) updated package in order to use eslint and nyc
1c8c164
@z3dev
fix(stl-deserializer) initial version 2 code with lots of changes
ba3ddc8
@z3dev
fix(stl-deserializer) rename tests directory
05e7c91
@z3dev
fix(stl-deserializer) split test suite into translate and instantiate
646478f
@z3dev
fix(stl-deserializer) changes to use primitives.polyhedron
fa62564
@z3dev
fix(stl-deserializer) added translate test for STL with colors
4a61451
@z3dev
fix(stl-deserializer) reworked translation, making function definitio…
79b4b32 
…ns for each solid

updated test suite for translation
@z3dev
fix(stl-deserializer) updated README to latest information
2f8c7b0
@z3dev
Merge branch 'V2' into v2-stl-deserializer
bd1facc
@z3dev
Merge branch V2 into v2-stl-deserializer
3a59ce0
@z3dev
fix(stl-deserializer) updated dependency for jscad/modeling
18f337f
@z3dev
fix(stl-deserializer) updated require to jscad/modeling
15ed1a6
@z3dev
fix(stl-deserializer) removed .gitignore in order to use main
4677279
@z3dev
fix(io-utils) updated dependency to jscad/modeling
c12d656
@z3dev
fix(io-utils) updated ensureManifoldness to use modeling, and tests
e55eafb
@z3dev
fix(io-utils) updated package to test with *.test.js
8c3e101
@z3dev
Copy link
Member Author

z3dev commented Dec 7, 2019 •
edited
Loading

BIG NOTE: ensureManaifoldness() is broken.

Do we want this to work? If so then an additional export of retessellate() is required as part of the modeling/booleans.

@z3dev z3dev requested a review from kaosat-dev December 7, 2019 02:06
kaosat-dev
kaosat-dev approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@kaosat-dev kaosat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !
Just a few things that I think are worth tweaking, but 99% all good !

packages/io/stl-deserializer/index.js Show resolved Hide resolved
packages/io/stl-deserializer/index.js Outdated Show resolved Hide resolved
packages/io/stl-deserializer/index.js Show resolved Hide resolved
packages/io/stl-deserializer/index.js Outdated Show resolved Hide resolved
packages/io/stl-deserializer/test/test.js Outdated Show resolved Hide resolved
packages/io/stl-deserializer/README.md Show resolved Hide resolved
packages/io/stl-deserializer/index.js Show resolved Hide resolved
packages/io/stl-deserializer/package.json Show resolved Hide resolved
packages/io/stl-deserializer/package.json Outdated Show resolved Hide resolved
packages/io/stl-deserializer/tests/instantiate.test.js Outdated Show resolved Hide resolved
@z3dev
Copy link
Member Author

z3dev commented Dec 17, 2019

@kaosat-dev please merge

@kaosat-dev kaosat-dev merged commit 6cd6be1 into V2 Dec 17, 2019
@kaosat-dev kaosat-dev deleted the v2-stl-deserializer branch January 7, 2020 08:14
@kaosat-dev kaosat-dev mentioned this pull request Feb 10, 2020
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaosat-dev kaosat-dev kaosat-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z3dev @kaosat-dev