Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 : test array utils #539

Merged
merged 3 commits into from
Mar 26, 2020
Merged

V2 : test array utils #539

merged 3 commits into from
Mar 26, 2020

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Mar 20, 2020

These changes complete a test suite for the array-utils module, covering all functions.

In addition, logic has been changed to use Array.isArray() to determine when a array is provided as a parameter. Document strings have also been improved.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@kaosat-dev kaosat-dev mentioned this pull request Mar 20, 2020
58 tasks
@kaosat-dev
Copy link
Contributor

This looks good to me , shall i merge ?

@z3dev
Copy link
Member Author

z3dev commented Mar 26, 2020

@kaosat-dev please merge. Thanks for the review!

@kaosat-dev kaosat-dev merged commit 60689d9 into V2 Mar 26, 2020
@kaosat-dev kaosat-dev deleted the v2-test-array-utils branch April 1, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants